Skip to content

Update yarn to 1.22.22#376

Merged
bjohnso5 merged 1 commit intoCircleCI-Public:mainfrom
DoodleBobBuffPants:update-yarn
Jun 21, 2024
Merged

Update yarn to 1.22.22#376
bjohnso5 merged 1 commit intoCircleCI-Public:mainfrom
DoodleBobBuffPants:update-yarn

Conversation

@DoodleBobBuffPants
Copy link
Contributor

@DoodleBobBuffPants DoodleBobBuffPants commented Nov 28, 2023 •
edited
Loading

For our official CircleCI Docker Convenience Image support policy, please see CircleCI docs.

This policy outlines the release, update, and deprecation policy for CircleCI Docker Convenience Images.

Description

A brief description of the changes in this PR.

Updates yarn from 1.22.19 to 1.22.22

Reasons

Please provide reasoning for these changes and how this PR achieves them.

If applicable, include a link to the related GitHub issue that this PR will close.

Patch version update to pick up fixes for yarnpkg/yarn#9005

Checklist

Please check through the following before opening your PR. Thank you!

  • I have made changes to the Dockerfile.template file only
  • I have not made any manual changes to automatically generated files
  • My PR follows best practices as described in the contributing guidelines
  • (Optional, but recommended) My commits are signed

@DoodleBobBuffPants DoodleBobBuffPants requested a review from a team as a code owner November 28, 2023 21:56
@JalexChen
Copy link

JalexChen commented Nov 30, 2023 •
edited
Loading

Hi @DoodleBobBuffPants - we are going off the classic stable release per yarn docs. Additionally, it looks like the newest versions of yarn have a couple of warnings against them on the releases page. I think placing this PR in the backlog until these are resolved so as to not break builds might be the best option for now.

@ryanbourdais - any thoughts?

@JalexChen JalexChen added the backlog Identified as a backlog item, often combined with low-priority and help-wanted labels label Dec 4, 2023
@schinery
Copy link
Contributor

schinery commented May 28, 2024

A 1.22.22 version has been released that doesn't have the don't use warnings in.

Screenshot 2024-05-28 at 13 50 37

@JalexChen would it be good for @DoodleBobBuffPants to update this PR to use that instead?

@schinery
Copy link
Contributor

schinery commented Jun 3, 2024

Maybe @DoodleBobBuffPants update this PR to 1.22.22 so it is good to go when someone gets around to looking at it again...

@DoodleBobBuffPants DoodleBobBuffPants changed the title Update yarn to 1.22.21 Update yarn to 1.22.22 Jun 4, 2024
@schinery
Copy link
Contributor

schinery commented Jun 10, 2024

@JalexChen do you think this is good now to get merged so it's available in the next Node releases?

@schinery schinery mentioned this pull request Jun 21, 2024
Closed
@bjohnso5 bjohnso5 merged commit 89d6216 into CircleCI-Public:main Jun 21, 2024
@vis97c
Copy link

vis97c commented Nov 23, 2024

This PR has introduced new issues on CI yarnpkg/yarn#9015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bjohnso5 bjohnso5 bjohnso5 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backlog Identified as a backlog item, often combined with low-priority and help-wanted labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DoodleBobBuffPants @JalexChen @schinery @vis97c @bjohnso5